Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Text Descriptions Sidebar #376

Merged
merged 18 commits into from
Sep 3, 2024
Merged

Updates to Text Descriptions Sidebar #376

merged 18 commits into from
Sep 3, 2024

Conversation

NateLanza
Copy link
Contributor

@NateLanza NateLanza commented Aug 1, 2024

Does this PR close any open issues?

Closes #373

Give a longer description of what this PR addresses and why it's needed

  • Implements UI changes for the text description sidebar based on meeting, including defaulting to the user-provided description in all cases
  • Fixes bug where saved plot information wouldn't load from a multinet state

Provide pictures/videos of the behavior before and after these changes (optional)

Have you added or updated relevant tests?

  • Yes
  • Not yet
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Review from Daniel
  • Review from team
  • Tests
  • Update this PR

@NateLanza NateLanza self-assigned this Aug 1, 2024
@NateLanza NateLanza linked an issue Aug 1, 2024 that may be closed by this pull request
8 tasks
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit d5ee030
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/66d78cadec740000089a5f8c
😎 Deploy Preview https://deploy-preview-376--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackWilb JackWilb marked this pull request as ready for review September 3, 2024 22:19
@NateLanza NateLanza requested a review from JackWilb September 3, 2024 22:35
@NateLanza NateLanza merged commit 1f9e396 into main Sep 3, 2024
7 checks passed
@NateLanza NateLanza deleted the 373-text-sidebar branch September 3, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Accessibility Sidebar
2 participants