-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
418 element view UI #433
base: main
Are you sure you want to change the base?
418 element view UI #433
Conversation
…on-bookmarked selections (bookmarked selections already have this functionality)
…that causes no other action
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…tersection by clicking its pill
@JakeWags Do you have a click handler somewhere other than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Check for additional click handlers that exist in the SVG Base element before merging.
// I cannot comprehend why this is the value that works. It is. | ||
// The 'rows per page' controls overflow otherwise (: | ||
paddingBottom: '1625px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to figure this out and I agree. Somewhat of a mystery...
Does this PR close any open issues?
Closes #418
Give a longer description of what this PR addresses and why it's needed
Provide pictures/videos of the behavior before and after these changes (optional)
Before:
After:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?