Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

418 element view UI #433

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

418 element view UI #433

wants to merge 7 commits into from

Conversation

NateLanza
Copy link
Contributor

@NateLanza NateLanza commented Nov 20, 2024

Does this PR close any open issues?

Closes #418

Give a longer description of what this PR addresses and why it's needed

  • Pads the bottom of the Element View so that the table controls don't overflow
  • Makes the 'Element View' h2 title larger than the h3 subtitles below
  • Allows deselecting the current intersection & current element selection by clicking their pills, even if they aren't bookmarked (this was previously implemented for bookmarked chips)
  • Allows deselecting the current intersection in the plot by clicking any element within SvgBase that doesn't have a different click handler

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
ev-ui-before
After:
ev-ui-after

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

@NateLanza NateLanza linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 75c7147
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/673d57d23be33000080a39b9
😎 Deploy Preview https://deploy-preview-433--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NateLanza NateLanza marked this pull request as ready for review November 20, 2024 02:36
@NateLanza NateLanza self-assigned this Nov 20, 2024
@NateLanza
Copy link
Contributor Author

@JakeWags Do you have a click handler somewhere other than SvgBase that's supposed to deselect the current intersection? If so, that should probably be removed given the new handler.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Check for additional click handlers that exist in the SVG Base element before merging.

Comment on lines +168 to +170
// I cannot comprehend why this is the value that works. It is.
// The 'rows per page' controls overflow otherwise (:
paddingBottom: '1625px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to figure this out and I agree. Somewhat of a mystery...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element View UI Updates
2 participants