feat(core) Add getWorldBounds() method #9920
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
changed the title
| ...transformOptions | ||
| }); | ||
|
|
||
| this._cachedWorldBounds = worldBounds; |
Collaborator
There was a problem hiding this comment.
core has a memoize utility function.
| const attributeManager = this.getAttributeManager(); | ||
| const {dataChanged} = params.changeFlags; | ||
| if (params.changeFlags.propsOrDataChanged || params.changeFlags.viewportChanged) { | ||
| this._worldBoundsDirty = true; |
Collaborator
There was a problem hiding this comment.
This is technically incorrect.
There are multiple existing caching mechanism (e.g. in layer.getBounds()) you should not have to manage a dirty flag manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deck.gl really needs the ability to exclude layers from being drawn based on bounds checks. And the existing getBounds function is not sufficient. As a first step, this PR adds a Layer.getWorldBounds() that returns a math.gl OrientedBoundingBox that applies modelMatrix coordinateSystem etc.
Testing
Codex Task