Skip to content

Commit

Permalink
flake8
Browse files Browse the repository at this point in the history
  • Loading branch information
vishesh10 committed Jun 19, 2024
1 parent be86b7a commit 5598f95
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 14 deletions.
13 changes: 8 additions & 5 deletions scrapy/commands/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
)
from scrapy.utils.misc import load_object


logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -191,14 +190,18 @@ def process_options(self, args: List[str], opts: argparse.Namespace) -> None:

def validate_feed_exporter(self, opts):
if opts.output:
default_extensions = [e for e in EXTENSIONS_BASE.keys() if e not in ['scrapy.extensions.feedexport.FeedExporter']]
default_extensions = [
e
for e in EXTENSIONS_BASE.keys()
if e not in ["scrapy.extensions.feedexport.FeedExporter"]
]
extensions = build_component_list(self.settings.getwithbase("EXTENSIONS"))
raise_warning = True

for ext in extensions:
if ext not in default_extensions:
for ext in extensions:
if ext not in default_extensions:
ext_cls = load_object(ext)
if issubclass(ext_cls, FeedExporter):
if issubclass(ext_cls, FeedExporter):
raise_warning = False
break

Expand Down
4 changes: 1 addition & 3 deletions tests/test_command_parse.py
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,5 @@ def test_exporter_disabled(self):
opts.output = ["example.json"]

command.validate_feed_exporter(opts)
expected = (
"Either 'FeedExporter' extension or its subclass must be enabled for Feed Exports to work."
)
expected = "Either 'FeedExporter' extension or its subclass must be enabled for Feed Exports to work."
self.assertTrue(any(expected in str for str in cm.output))
8 changes: 2 additions & 6 deletions tests/test_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -1004,9 +1004,7 @@ def test_exporter_disabled(self):
opts.output = ["example.json"]

command.validate_feed_exporter(opts)
expected = (
"Either 'FeedExporter' extension or its subclass must be enabled for Feed Exports to work."
)
expected = "Either 'FeedExporter' extension or its subclass must be enabled for Feed Exports to work."
self.assertTrue(any(expected in str for str in cm.output))


Expand Down Expand Up @@ -1096,9 +1094,7 @@ def test_exporter_disabled(self):
opts.output = ["example.json"]

command.validate_feed_exporter(opts)
expected = (
"Either 'FeedExporter' extension or its subclass must be enabled for Feed Exports to work."
)
expected = "Either 'FeedExporter' extension or its subclass must be enabled for Feed Exports to work."
self.assertTrue(any(expected in str for str in cm.output))

def test_output(self):
Expand Down

0 comments on commit 5598f95

Please sign in to comment.