Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various module improvements #165

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Various module improvements #165

merged 13 commits into from
Aug 23, 2023

Commits on Jun 20, 2023

  1. more descriptive spline coupling error, when discriminant is negative

    @RussellALA
    RussellALA committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2577189 View commit details
    Browse the repository at this point in the history

  2. permutation in AllInOneBlock now via index tensor (saves resolution**… 

    …2 parameters in image case)
    @RussellALA
    RussellALA committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3ca46d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. fixed soft clamping in all in one block (higher values no longer scal… 

    …e model output)
    @RussellALA
    RussellALA committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ae74fd4 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. added a new parameter domain_clamping to BinnedSplineBase, which soft… 

    …-clamps the width of the spline to (-domain_clampling, domain_clamping). Since the total width before clamping is always > 0, effectively the domain is clamped to (0, domain_clamping).
    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d748f44 View commit details
    Browse the repository at this point in the history

  2. constructed actnorm with full input shape instead of just the channel… 

    …s to be in line with the original actnorm implementation of glow. This full shape was already used when actnorm is initialized, but the inconsistency in the constructor prevented loading of >1D actnorm models.
    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f5690e3 View commit details
    Browse the repository at this point in the history

  3. fixed shape for actnorm constructor

    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    120c520 View commit details
    Browse the repository at this point in the history

  4. deleted unused hard permutation matrix in AllInOne block, more explic… 

    …it docstring for BinnedSplineBase domain_clamping
    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ff7221a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'VariousModuleImprovements' of github.com:vislearn/FrEIA… 

    … into VariousModuleImprovements
    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    612d7c6 View commit details
    Browse the repository at this point in the history

  6. made clamp_domain a class method instead of lambda, changed discrimin… 

    …ant assertion in rational quadratic splines runtime error, raise runtime error in allinone block if x does not match dims
    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5896c1b View commit details
    Browse the repository at this point in the history

  7. unwrap input in dimension check AllInOne block

    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e4b1253 View commit details
    Browse the repository at this point in the history

  8. proper unwrap in AIO block, changed from torch.tensor(numpy) to torch… 

    ….from_numpy(numpy) and tensor.view() to tensor.view().contiguous()
    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b983024 View commit details
    Browse the repository at this point in the history

  9. fixed typing in AIO input check

    @RussellALA
    RussellALA committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    31ef2b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. soft permutes in AIO now initialize of type float

    @RussellALA
    RussellALA committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4068375 View commit details
    Browse the repository at this point in the history