Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #170

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules
**node_modules
**package.json
4 changes: 4 additions & 0 deletions lib/controllers/ExplorerController.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ class ExplorerController{
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.getAmountOfExplorersByMission(explorers, mission);
}
static getExplorersByStack(stack){
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.getExplorersByStack(explorers, stack);
}
}

module.exports = ExplorerController;
6 changes: 5 additions & 1 deletion lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ app.get("/v1/fizzbuzz/:score", (request, response) => {
const fizzbuzzTrick = ExplorerController.applyFizzbuzz(score);
response.json({score: score, trick: fizzbuzzTrick});
});

app.get("/v1/explorers/stack/:stack", (request, response)=>{
const stack = request.params.stack;
const filtered = ExplorerController.getExplorersByStack(stack);
response.json(filtered);
});
app.listen(port, () => {
console.log(`FizzBuzz API in localhost:${port}`);
});
Expand Down
9 changes: 8 additions & 1 deletion lib/services/ExplorerService.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ class ExplorerService {
const explorersUsernames = explorersByMission.map((explorer) => explorer.githubUsername);
return explorersUsernames;
}

static getExplorersByStack(explorers, stack){
const explorersWithStack = explorers.filter((explorer) => {
if(explorer.stacks.includes(stack))
return explorer;
});
return explorersWithStack;
}
}


module.exports = ExplorerService;
9 changes: 4 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions test/services/ExplorerService.test.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,26 @@
const Reader = require("../../lib/utils/reader");
const ExplorerService = require("./../../lib/services/ExplorerService");
const explorers = Reader.readJsonFile("explorers.json");

describe("Tests para ExplorerService", () => {
test("Requerimiento 1: Calcular todos los explorers en una misión", () => {
const explorers = [{mission: "node"}];
const explorersInNode = ExplorerService.filterByMission(explorers, "node");
expect(explorersInNode.length).toBe(1);
});
test("2. Filtrar los explorers por stack", ()=>{
const explorers = Reader.readJsonFile("explorers.json");
const filter = ExplorerService.getExplorersByStack(explorers, "javascript");
const filter1 = ExplorerService.getExplorersByStack(explorers, "elm");
const filter2 = ExplorerService.getExplorersByStack(explorers, "groovy");
const filter3 = ExplorerService.getExplorersByStack(explorers, "reasonML");
const filter4 = ExplorerService.getExplorersByStack(explorers, "elixir");

for(let i =0; i<filter.length; i++){expect(filter[i].stacks).toContain("javascript");}
for(let i =0; i<filter1.length; i++){expect(filter1[i].stacks).toContain("elm");}
for(let i =0; i<filter2.length; i++){expect(filter2[i].stacks).toContain("groovy");}
for(let i =0; i<filter3.length; i++){expect(filter3[i].stacks).toContain("reasonML");}
for(let i =0; i<filter4.length; i++){expect(filter4[i].stacks).toContain("elixir");}
});

});