Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the execute command, interactive plan editor, custom PR body templates, and the --notify webhook flag. It also updates the configuration table and the 'What it does' section in README.md to reflect these new features.
Greptile SummaryThis PR is a documentation-only update to All documented behaviours were verified against the source:
Two minor style suggestions were left inline: clarifying that the interactive editor is scoped to Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pr-split split --dry-run] --> B[Plan displayed + Interactive Editor]
B --> C{User action}
C -->|done / Enter| D[Save plan to .pr-split/plan.json]
C -->|abort| E[Cancel]
D --> F[pr-split execute]
F --> G[Load saved diff + merge base]
G --> H[Display plan]
H --> I{Confirm?}
I -->|Yes| J[Create branches & commits]
J --> K[Push & open PRs]
K --> L[pr-split merge --notify URL]
L --> M[Merge in DAG order]
M --> N[POST results to webhook]
Prompt To Fix All With AIThis is a comment left during a code review.
Path: README.md
Line: 119
Comment:
**Interactive editor availability not scoped to `split`**
The "Interactive plan editing" section is placed after the `execute` command section with no indication it only applies to `split`. Since `execute` also shows a plan and prompts for confirmation (but does **not** invoke the interactive editor), readers may expect to edit the plan during `execute` and be confused when it doesn't happen.
Consider adding a clarifying note, for example:
```suggestion
After running `pr-split split`, the plan is displayed and an interactive editor lets you adjust the plan before confirming:
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: README.md
Line: 123
Comment:
**Hunk indices are 0-based — worth noting**
The code enforces `hunk_index >= 0` and displays indices as `0, 1, 2, …` in the `show` output (see `_show_group_detail`). The example `src/foo.py:2` refers to the third hunk. Documenting that indices are 0-based (as shown by `show <group>`) would prevent off-by-one errors for users.
```suggestion
edit> move src/foo.py:2 pr-1 pr-2 # move hunk at index 2 (0-based) from pr-1 to pr-2
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "docs: add execute, interactive editor, t..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| ### Interactive plan editing | ||
|
|
||
| After the plan is displayed, an interactive editor lets you adjust the plan before confirming: |
There was a problem hiding this comment.
split
The "Interactive plan editing" section is placed after the execute command section with no indication it only applies to split. Since execute also shows a plan and prompts for confirmation (but does not invoke the interactive editor), readers may expect to edit the plan during execute and be confused when it doesn't happen.
Consider adding a clarifying note, for example:
| After the plan is displayed, an interactive editor lets you adjust the plan before confirming: | |
| After running `pr-split split`, the plan is displayed and an interactive editor lets you adjust the plan before confirming: |
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 119
Comment:
**Interactive editor availability not scoped to `split`**
The "Interactive plan editing" section is placed after the `execute` command section with no indication it only applies to `split`. Since `execute` also shows a plan and prompts for confirmation (but does **not** invoke the interactive editor), readers may expect to edit the plan during `execute` and be confused when it doesn't happen.
Consider adding a clarifying note, for example:
```suggestion
After running `pr-split split`, the plan is displayed and an interactive editor lets you adjust the plan before confirming:
```
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| ``` | ||
| edit> show pr-1 # inspect a group's assignments | ||
| edit> move src/foo.py:2 pr-1 pr-2 # move a hunk between groups |
There was a problem hiding this comment.
The code enforces hunk_index >= 0 and displays indices as 0, 1, 2, … in the show output (see _show_group_detail). The example src/foo.py:2 refers to the third hunk. Documenting that indices are 0-based (as shown by show <group>) would prevent off-by-one errors for users.
| edit> move src/foo.py:2 pr-1 pr-2 # move a hunk between groups | |
| edit> move src/foo.py:2 pr-1 pr-2 # move hunk at index 2 (0-based) from pr-1 to pr-2 |
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 123
Comment:
**Hunk indices are 0-based — worth noting**
The code enforces `hunk_index >= 0` and displays indices as `0, 1, 2, …` in the `show` output (see `_show_group_detail`). The example `src/foo.py:2` refers to the third hunk. Documenting that indices are 0-based (as shown by `show <group>`) would prevent off-by-one errors for users.
```suggestion
edit> move src/foo.py:2 pr-1 pr-2 # move hunk at index 2 (0-based) from pr-1 to pr-2
```
How can I resolve this? If you propose a fix, please make it concise.
1 participant
Summary
executecommand for running saved dry-run plans.pr-split/template.md--notifywebhook flag for merge notificationsPR_SPLIT_WEBHOOK_URLto configuration tableTest plan