Skip to content

feat: add Nix package output for installable u7 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitali87 merged 5 commits into from
Mar 27, 2026
Merged

feat: add Nix package output for installable u7 #42

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
286321a
feat: add Nix package output for installable u7
vitali87 Mar 24, 2026
8f00f27
fix: add dontBuild, filter src, move bash to runtimeDeps, bash-comple…
vitali87 Mar 24, 2026
757fdd8
fix: use makeWrapper instead of wrapProgram to avoid binary rename is…
vitali87 Mar 24, 2026
d6ee4dc
fix: use direct scripts with proper shebang instead of makeWrapper fo…
vitali87 Mar 24, 2026
865dd05
fix: address Greptile review feedback on flake.nix
vitali87 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 62 additions & 37 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,45 +9,70 @@
outputs = { self, nixpkgs, flake-utils}:
flake-utils.lib.eachDefaultSystem (
system:
let
let
pkgs = nixpkgs.legacyPackages.${system};
in

runtimeDeps = [
pkgs.curl
pkgs.jq
pkgs.ripgrep
pkgs.fd
pkgs.qsv

pkgs.coreutils
pkgs.gnused
pkgs.gawk
pkgs.findutils
pkgs.gnugrep

pkgs.bc
pkgs.ffmpeg
pkgs.imagemagick
pkgs.gnutar
pkgs.gzip
pkgs.bzip2
pkgs.xz
pkgs.p7zip
pkgs.unzip

pkgs.rsync

pkgs.bash
Copy link
Copy Markdown

@greptile-apps greptile-apps bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 pkgs.bash silently added to devShells.default

Since devShells.default is built from runtimeDeps ++ [ pkgs.bash-completion ] (line 84), pkgs.bash is now part of devShells.default.buildInputs. This changes the devShell's PATH compared to the previous behaviour (where Nix's bash was not in the shell's packages). On macOS in particular, having Nix's bash prepended to PATH ahead of the system bash can subtly change shell behaviour for developers who rely on the system bash.

Consider separating pkgs.bash into the packages.default-specific list rather than the shared runtimeDeps, or at least call this out in the PR description.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: flake.nix
Line: 40

Comment:
**`pkgs.bash` silently added to `devShells.default`**

Since `devShells.default` is built from `runtimeDeps ++ [ pkgs.bash-completion ]` (line 84), `pkgs.bash` is now part of `devShells.default.buildInputs`. This changes the devShell's PATH compared to the previous behaviour (where Nix's bash was not in the shell's packages). On macOS in particular, having Nix's bash prepended to PATH ahead of the system bash can subtly change shell behaviour for developers who rely on the system bash.

Consider separating `pkgs.bash` into the `packages.default`-specific list rather than the shared `runtimeDeps`, or at least call this out in the PR description.

How can I resolve this? If you propose a fix, please make it concise.


pkgs.openssl
pkgs.yq-go
pkgs.git

pkgs.libwebp
pkgs.gifsicle
pkgs.rename
];
in
{
packages.default = pkgs.stdenv.mkDerivation {
pname = "u7";
version = "0.1.0";
src = pkgs.lib.cleanSource ./.;
dontBuild = true;

buildInputs = runtimeDeps;
nativeBuildInputs = [ pkgs.makeWrapper ];

installPhase = ''
mkdir -p $out/share/u7 $out/bin
cp utility.sh $out/share/u7/utility.sh

makeWrapper ${pkgs.bash}/bin/bash $out/bin/u7 \
--prefix PATH : ${pkgs.lib.makeBinPath runtimeDeps} \
--add-flags '-c "source ${placeholder "out"}/share/u7/utility.sh; u7 \"\$@\"" --'

makeWrapper ${pkgs.bash}/bin/bash $out/bin/u7-init \
--add-flags '-c "echo ${placeholder "out"}/share/u7/utility.sh"'
'';
};

devShells.default = pkgs.mkShell {
buildInputs = [
pkgs.curl
pkgs.jq
pkgs.ripgrep
pkgs.fd
pkgs.qsv

pkgs.coreutils
pkgs.gnused
pkgs.gawk
pkgs.findutils
pkgs.gnugrep

pkgs.bc
pkgs.ffmpeg
pkgs.imagemagick
pkgs.gnutar
pkgs.gzip
pkgs.bzip2
pkgs.xz
pkgs.p7zip
pkgs.unzip

pkgs.rsync

pkgs.openssl
pkgs.yq-go
pkgs.git
pkgs.bash-completion

pkgs.libwebp
pkgs.gifsicle
pkgs.rename
];
buildInputs = runtimeDeps ++ [ pkgs.bash-completion ];

shellHook = ''
source ${pkgs.bash-completion}/etc/profile.d/bash_completion.sh
Expand All @@ -58,4 +83,4 @@
};
}
);
}
}
Loading