Restore support to do template-syntax lookups for nested dicts. #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch skips the lookup for regular "single" key-access to not return default value from defaultdicts. Nested defaultdicts will however return the default value instead of "missing" due to how Django's Variable.resolve(key) works.
johnbergvall
force-pushed
the
fix-nested-dict-lookup
branch
from
4fd37e0
to
ab110e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores template syntax-lookup with nested dicts as input which were supported pre v1.0.
One caveat is that nested lookups (
dict1.key) will return defaultdict default value, where single lookups (key) will returnmissing.Also returning empty values for nested defaultdict is possible but would require a custom lookup function instead of using Django Variable.resolve(). However I think it's such an uncommon case that it does not motivate the extra maintenance