-
-
Notifications
You must be signed in to change notification settings - Fork 527
Add union type and subtypes check in schema model signature (with tests) #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add union type and subtypes check in schema model signature (with tests) #1512
Conversation
25c2171
to
53d0b20
Compare
53d0b20
to
f5694c0
Compare
I've rebased this since it got a little stale |
Hi @dan-blanchard - could you add missing tests coverage on ninja/signature/details.py lines - 212-215, 355-368 |
Note: #1483 can be related |
f5694c0
to
63d426b
Compare
if self.streaming: | ||
self.content = b"".join(http_response.streaming_content) # type: ignore | ||
else: | ||
self.content = http_response.content # type: ignore[union-attr] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy was complaining about this ignore being unnecessary for me
I rebased this on |
This PR is a rebased version of #1242 that also:
if type(arg) is None:
instead ofif arg is type(None):