Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary use Vike's brillout/pnpm-8 branch #308

Closed
wants to merge 1 commit into from

Conversation

brillout
Copy link
Contributor

@brillout brillout commented Jun 2, 2024

Vike's main branch uses pnpm 9 while vite-ecosystem-ci uses pnpm 8. This causes vite-ecosystem-ci + Vike to fail.

This PR is a temporary workaround. I'll revert this PR once Vite uses pnpm 9.

@dominikg
Copy link
Collaborator

dominikg commented Jun 2, 2024

we should figure out a way how to run projects on different majors instead, this would otherwise force projects to provide a compatible branch like this one for every pnpm major update

@patak-dev
Copy link
Member

Agreed, let's close this one.

@patak-dev patak-dev closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants