chore(rsc): server function error handling example #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements error handling for server functions using React error boundaries, allowing server-side errors to naturally propagate to the client and trigger error boundaries. This is based on the Next.js pattern where server function results are returned as promises, enabling rejections to be caught by error boundaries.
Key changes:
- Server action return values are now returned as promises without awaiting, allowing rejections to propagate to the client
- Added an ErrorBoundary component to catch and display server function errors
- Wrapped the App component with ErrorBoundary in the root
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-rsc/examples/starter/src/framework/entry.rsc.tsx | Modified to return server action results as promises without awaiting, enabling error propagation to client-side error boundaries |
| packages/plugin-rsc/examples/starter/src/client.tsx | Added ErrorBoundary class component to catch and display errors with a reset button |
| packages/plugin-rsc/examples/starter/src/root.tsx | Wrapped the App component with ErrorBoundary to enable error catching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hi-ogawa
force-pushed
the
11-11-chore_rsc_server_function_error_handling_example
branch
from
1711122 to
c4b90f5
Compare
hi-ogawa
deleted the
11-11-chore_rsc_server_function_error_handling_example
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #795
I just found the idea of returning server function result as promise on Next.js. This naturally propagates server function error as rejection, which can trigger error boundary on browser. https://github.com/hi-ogawa/reproductions/tree/main/next-error
Hmm, this isn't entirely better since it now returns http status 200 on such action response. Next.js actually keeps 500 somehow. For example, for production server logging / monitoring, indicating server response error code is probably essential.
Okay, so we still need to await to reflect the status code https://github.com/vercel/next.js/blob/28a14da5010ad3147a06abbabc99a119d009f733/packages/next/src/server/app-render/action-handler.ts#L1124-L1125
TODO: