fix(html): fix inconsistency in resolving alias in dev and build mode.

[smeng9]

Fixes #17910

[bluwy]

The visitor function when traversing shouldn't be async as it'll run slower. We had styleUrl and inlineStyles to avoid that, and if we need to make processNodeUrl async, it should probably follow a similar pattern.

Though about the feature as a whole, I wonder if it's feasible to support it entirely in dev to match build. E.g. do we also want to support specify dependency names like <script type="module" src="my-lib" /> or <link rel="stylesheet" href="normalize.css" />. To align it completely it would have to match the normalizeUrl function in importAnalysis.ts.

My initial hunch is that we don't have to fix #17910. Build has to match dev (and free to extend), but dev doesn't have to match build 🤔

[smeng9]

That sounds good to make build match dev (and free to extend), but dev doesn't have to match build.

[bluwy]

Maybe good to have @sapphi-red's opinion on this too

[sapphi-red]

I think it'd be nice to make build match to dev too. It's not important than making dev to match build though.

In this case, I think changing the build's behavior to align with dev is also a choice. I hope that won't break anything in ecosystem-ci.

[bluwy]

My opinion was actually we don't have to shrink down the build behaviour to the same level as dev. The dev server is where you'd spend most of your time on and becomes the source of truth. Build is an optimization step before deploying, so if it supports something else out of scope of dev, it doesn't matter since you don't realistically develop against build all the time.

We could shrink it down if it's easy, but if not I think it's acceptable to leave it as is too.

[sapphi-red]

Yeah, I won't say it's necessary. But I'd be open to align them unless the implementation gets much complicated.