fix: environments might be an empty object #19207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
False alarm, the code is correct, it's an error in a consumer package, sorry for the noise 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey! Small fix needed after Vite v6:
topLevelConfig.environmentsmight be an empty object, as there are no default environment anymore.This will probably be needed as long as some environments are hardcoded:
vite/packages/vite/src/node/plugins/css.ts
Lines 1586 to 1589 in 3400a5e
I can try to provide some test cases, but I'm not sure how to do so. Please bear with me!