chore(create-vite): move common ts settings to base tsconfig
#19228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussed this briefly with @ArnaudBarre on Discord, this is a proposal to avoid duplication between tsconfigs.
Some Vite starter templates with typescript include
tsconfig.json
that referencestsconfig.app.json
andtsconfig.node.json
. A lot of settings betweenapp
andnode
configs are repeated. This PR moves shared config props to roottsconfig.json
and makestsconfig.app.json
andtsconfig.node.js
inheritcompilerOptions
from it.This works because
references
are excluded from inheritance (see https://www.typescriptlang.org/tsconfig/#extends)