Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: backport #19234, fix GHSA-vg6x-rcgg-rjx6 #19235

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 20, 2025

Description

backport of #19234, see GHSA-vg6x-rcgg-rjx6

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for vite-docs-v5 ready!

Name Link
🔨 Latest commit 18f1045
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-v5/deploys/678e10bf2e3f140008e9d39d
😎 Deploy Preview https://deploy-preview-19235--vite-docs-v5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sapphi-red sapphi-red changed the title fix!: test (v5) fix!: backport #19234, test Jan 20, 2025
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@sapphi-red sapphi-red changed the title fix!: backport #19234, test fix!: backport #19234, GHSA-vg6x-rcgg-rjx6 Jan 20, 2025
@sapphi-red sapphi-red changed the title fix!: backport #19234, GHSA-vg6x-rcgg-rjx6 fix!: backport #19234, fix GHSA-vg6x-rcgg-rjx6 Jan 20, 2025
@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 18f1045: Open

suite result latest scheduled
analogjs failure failure
astro failure success
histoire failure failure
marko failure success
nuxt success failure
previewjs failure success
react-router failure success
redwoodjs failure failure
sveltekit failure success
vike failure success
vite-plugin-react failure success
vite-plugin-svelte failure failure
vite-setup-catalogue failure success
vitest success failure
waku failure failure

ladle, laravel, quasar, qwik, rakkas, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react-swc, vite-plugin-vue, vitepress, vuepress

@sapphi-red sapphi-red marked this pull request as ready for review January 20, 2025 09:19
@sapphi-red sapphi-red merged commit 9da4abc into vitejs:v5 Jan 20, 2025
15 of 16 checks passed
@sapphi-red sapphi-red deleted the fix/v5-ghsa-vg6x-rcgg-rjx6 branch January 20, 2025 09:21
@emargareten
Copy link

This change brakes my workflows

error during build:
TypeError: Invalid URL
    at new URL (node:internal/url:816:29)
    at getAdditionalAllowedHosts (file:///xxxxx/xxxxx/node_modules/vite/dist/node/chunks/dep-BdTvomPN.js:37687:29)
    at resolveConfig (file:///xxxxx/xxxxx//node_modules/vite/dist/node/chunks/dep-BdTvomPN.js:53812:29)
    at async createBuilder (file:///xxxxx/xxxxx//node_modules/vite/dist/node/chunks/dep-BdTvomPN.js:51529:18)
    at async CAC.<anonymous> (file:///xxxxx/xxxxx//node_modules/vite/dist/node/cli.js:852:23)
error when starting dev server:
TypeError: Invalid URL
    at new URL (node:internal/url:816:29)
    at getAdditionalAllowedHosts (file:///xxxxx/xxxxx/node_modules/vite/dist/node/chunks/dep-BdTvomPN.js:37687:29)
    at resolveConfig (file:///xxxxx/xxxxx//node_modules/vite/dist/node/chunks/dep-BdTvomPN.js:53812:29)
    at async createBuilder (file:///xxxxx/xxxxx//node_modules/vite/dist/node/chunks/dep-BdTvomPN.js:51529:18)
    at async CAC.<anonymous> (file:///xxxxx/xxxxx//node_modules/vite/dist/node/cli.js:852:23)

@patak-dev
Copy link
Member

@emargareten please create an issue with a minimal reproduction so we can track it

@laserhybiz laserhybiz mentioned this pull request Jan 20, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants