-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
feat(optimizer): add rush lockfile support #20833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: sapphi-red <[email protected]>
Co-authored-by: sapphi-red <[email protected]>
Co-authored-by: sapphi-red <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should also uncomment this if we somewhat have rush support now:
// 'rush.json', |
It was added in https://github.com/vitejs/vite/pull/2850/files#diff-64df9f2b7e879d5f5da8a632345e240f078cbb36a258ec5c92752744d02a87c9R13
I think we can add that too (maybe also with nx #20090). But I guess we should add it in a major because it will allow more files in |
packages/vite/src/node/optimizer/index.ts
getLockfileHash
function andlockfileFormats
array.rush/temp/shrinkwrap-deps.json
tolockfileFormats
Implementation Details
Rush.js Lockfile Support
Added Rush.js lockfile format to the
lockfileFormats
array to enable automatic detection of.rush/temp/shrinkwrap-deps.json
files. The entry is positioned right after the pnpm lockfile entry since Rush.js uses pnpm internally.This minimal change resolves the core issue where Vite fails to work with Rush.js monorepos due to non-standard lockfile locations, without adding any new configuration options.
Additional instructions:
Fixes #20817
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.