fix(css): improve url escape characters handling #20847
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve CSS URL parsing and replacement logic in Vite - update `cssUrlRE` regex to fully capture URLs containing escaped characters - add unescape operation in `doUrlReplace` to remove backslashes from captured URLs - enhance quote-handling in `doUrlReplace`, automatically wrapping URLs with unescaped parentheses in quotes - add a test case to verify the above changes behave as expected
|
Reverted the changes to server-source-maps.spec.ts and the tests passed. |
bluwy
reviewed
Oct 1, 2025
bluwy
changed the title
bluwy
previously approved these changes
Oct 2, 2025
sapphi-red
added
feat: css
p2-edge-case
sapphi-red
reviewed
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What I did?
improve CSS URL parsing and replacement logic in Vite
cssUrlREregex to fully capture URLs containing escaped charactersdoUrlReplaceto remove backslashes from captured URLsdoUrlReplace, automatically wrapping URLs with unescaped parentheses in quotesTesting:
Ran
pnpm test— no errorsSteps to Reproduce(test code removed):
Added the following code in
playground/htmlto match the issue description:Ran
pnpm buildExpected Result:
The built output correctly handles escaped parentheses and wraps the URL in quotes:
P.S. Due to snapshot errors, ran pnpm test --update (resulting in no errors). This seems to have caused changes in js-sourcemap.spec.ts and pnpm-lock.yaml; it is unclear whether these changes are erroneous.
Fixes #20816