Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed dynamic import lose vue style after build cjs (fix #4277) #4954

Closed
wants to merge 3 commits into from

Conversation

Veiintc
Copy link

@Veiintc Veiintc commented Sep 17, 2021

Description

fixed vitejs/vite-plugin-vue#27
when dynamic import vue file
before vite 2.1.5 build format cjs ,vite create style label to import css
but after vite 2.1.5 build format cjs ,vite create css file but nowhere to import it

use https://github.com/Veiintc/vite-cjs-csslose Recurrence problem

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes vitejs/vite#123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Veiintc Veiintc changed the title fix: fixed dynamic import lose vue style after build cjs (close #4277) fix: fixed dynamic import lose vue style after build cjs (fix #4277) Sep 17, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Sep 17, 2021
@bluwy
Copy link
Member

bluwy commented Apr 1, 2023

Sorry for the lack of response here. We're slowly moving away of CJS now, and I don't think this is something we want to support now. I'd suggest moving to ESM if possible. Closing for now, but thanks for kicking off this PR!

@bluwy bluwy closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when outfile format cjs,vue style lose from dynamic import
3 participants