Skip to content

GTID and other go/mysql and vstreamer optimizations #18196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlomi-noach merged 18 commits into from
Aug 26, 2025

empty commit to kick CI

b8ec791
Select commit
Loading
Failed to load commit list.
Merged

GTID and other go/mysql and vstreamer optimizations #18196

empty commit to kick CI
b8ec791
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 25, 2025 in 0s

67.52% (+0.02%) compared to 104b755

View this Pull Request on Codecov

67.52% (+0.02%) compared to 104b755

Details

Codecov Report

❌ Patch coverage is 74.87923% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (104b755) to head (b8ec791).

Files with missing lines Patch % Lines
go/mysql/replication/mariadb_gtid.go 12.50% 14 Missing ⚠️
go/mysql/replication/replication_position.go 46.15% 14 Missing ⚠️
go/mysql/replication/mysql56_gtid_set.go 92.63% 7 Missing ⚠️
go/vt/vttablet/tabletserver/vstreamer/vstreamer.go 79.31% 6 Missing ⚠️
go/mysql/binlog_event_filepos.go 33.33% 4 Missing ⚠️
go/mysql/replication/filepos_gtid.go 50.00% 4 Missing ⚠️
go/mysql/replication/mysql56_gtid.go 60.00% 2 Missing ⚠️
go/vt/binlog/binlog_streamer.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18196      +/-   ##
==========================================
+ Coverage   67.49%   67.52%   +0.02%     
==========================================
  Files        1607     1607              
  Lines      263144   263324     +180     
==========================================
+ Hits       177621   177805     +184     
+ Misses      85523    85519       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov