-
Notifications
You must be signed in to change notification settings - Fork 2.2k
vtorc
: add flag to set collection metric retention/ttl
#18619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
vtorc
: add flag to set collection metric retention/ttl
#18619
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18619 +/- ##
==========================================
- Coverage 67.49% 67.49% -0.01%
==========================================
Files 1607 1607
Lines 263518 263522 +4
==========================================
+ Hits 177849 177851 +2
- Misses 85669 85671 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
…ction-retention-seconds-flag Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@@ -1036,7 +1036,7 @@ func WaitForSuccessfulERSCount(t *testing.T, vtorcInstance *cluster.VTOrcProcess | |||
vars := vtorcInstance.GetVars() | |||
ersCountsMap := vars["EmergencyReparentCounts"].(map[string]interface{}) | |||
successCount := GetIntFromValue(ersCountsMap[mapKey]) | |||
assert.EqualValues(t, countExpected, successCount) | |||
assert.EqualValues(c, countExpected, successCount) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated fix to my last PR
Description
This PR adds the flag
--discovery-collection-metrics-ttl duration
for setting the time-to-live for discovery collection metrics (default 2m0s). This data seems to be used for the aggregated metrics HTTP API only.This replaces the hardcoded
120
seconds that exists today. In some situations this can lead to a lot of metrics being stored, for example a host monitoring 3000 tablets every 2s will store 180,000 metrics at the120
second expiryRelated Issue(s)
Resolves #18620
Checklist
Deployment Notes