Skip to content

Performance: use IsSingleShard() check in pushDerived instead of just engine.EqualUnique opcode #18974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChaitanyaD48 wants to merge 4 commits into
base: main
Choose a base branch
from
+24 −2
Open

Performance: use IsSingleShard() check in pushDerived instead of just engine.EqualUnique opcode #18974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ccbd53
update condition in pushDerived to check for single shard routing
ChaitanyaD48 Dec 2, 2025
4304f72
Merge branch 'main' of github.com:ChaitanyaD48/vitess into perf/pushD…
ChaitanyaD48 Dec 18, 2025
6ed516f
test: add reference case for derived table pushdown optimization
ChaitanyaD48 Dec 18, 2025
c0ba3a1
Merge branch 'main' of github.com:ChaitanyaD48/vitess into perf/pushD…
ChaitanyaD48 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/route_planning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func pushDerived(ctx *plancontext.PlanningContext, op *Horizon) (Operator, *Appl
return op, NoRewrite
}

if (innerRoute.Routing.OpCode() != engine.EqualUnique) && !op.IsMergeable(ctx) {
if !innerRoute.Routing.OpCode().IsSingleShard() && !op.IsMergeable(ctx) {
// no need to check anything if we are sure that we will only hit a single shard
return op, NoRewrite
}
Expand Down
24 changes: 23 additions & 1 deletion go/vt/vtgate/planbuilder/testdata/reference_cases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,5 +893,27 @@
"user.music"
]
}
},
{
"comment": "Derived table pushdown optimization",
"query": "SELECT * FROM (SELECT DISTINCT id, col FROM user.ref WHERE id = 1 LIMIT 10) as sub",
"plan": {
"Type": "Passthrough",
"QueryType": "SELECT",
"Original": "SELECT * FROM (SELECT DISTINCT id, col FROM user.ref WHERE id = 1 LIMIT 10) as sub",
"Instructions": {
"OperatorType": "Route",
"Variant": "Reference",
"Keyspace": {
"Name": "user",
"Sharded": true
},
"FieldQuery": "select id, col from (select id, col from ref where 1 != 1) as sub where 1 != 1",
"Query": "select id, col from (select distinct id, col from ref where id = 1 limit 10) as sub"
},
"TablesUsed": [
"user.ref"
]
}
}
]
]
Loading