Skip FOR...UPDATE Clause in Warming Reads Queries

[esignorelli]

Description

We are addressing the bug involving SELECT...FOR UPDATE queries in warming reads which resulted in errors such as
Error 1290: The MySQL server is running with the --read-only option so it cannot execute this statement by removing the locks related to the "FOR UPDATE" clause in the warming read queries

We tested this change at HubSpot on Vitess v22 and request a backport to that version for us to use

Related Issue(s)

Fixes #19059

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

AI Disclosure

I wrote the primary change in routes.go. Claude Code was used in creating the tests. I reviewed all Claude-generated test code.

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[promptless]

📝 Documentation updates detected!

New suggestion: Document warming reads feature and SELECT...FOR UPDATE exclusion

[codecov]

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.90%. Comparing base (e48c2d5) to head (ee058cf).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtgate/engine/route.go	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #19060      +/-   ##
==========================================
- Coverage   69.90%   69.90%   -0.01%     
==========================================
  Files        1612     1612              
  Lines      215796   215814      +18     
==========================================
+ Hits       150858   150868      +10     
- Misses      64938    64946       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.