-
Notifications
You must be signed in to change notification settings - Fork 2.3k
mysqlctl: add CloneFromDonor
#19064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
mysqlctl: add CloneFromDonor
#19064
Changes from 29 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
5458bcd
mysqlctl: add MySQL CLONE support infrastructure
nickvanw 0fe8efd
add flags to tests + fix errors from linters
nickvanw 8941459
fix up more tests
nickvanw 94624dc
go/vt/mysqlctl: add CloneFromDonor
maxenglander 0342d74
actually validate the source and destination, and poll for the copy t…
nickvanw 95dccd1
TestCloneFromDonor: add a few cases
maxenglander ba66344
merge <- clone-infrastructure
maxenglander e66d1ee
more tests
maxenglander 0d57e26
make it nicer
maxenglander 06a370b
make tests nicer
maxenglander 88340e5
slight reorg add comments
maxenglander 01fabc0
fix imports
maxenglander ca83a7a
fix lint
maxenglander 2cdb9c4
one more lint
maxenglander 66e4998
tidy
maxenglander 8633eaf
add an end to end test and do some cleanup
nickvanw 13ace33
use time tickers in the for loop
nickvanw 43a534f
tmrpctest: fix flaky TestGRPCTMServer timeout test
nickvanw 0599231
Merge branch 'clone-infrastructure' into clone-from-donor
maxenglander dbe89f7
fix test
maxenglander b44ad0f
rm redundant clone sql init
maxenglander d40490b
Merge branch 'clone-infrastructure' into clone-from-donor
maxenglander 2be837f
merge <- main
maxenglander 1634726
fix imports
maxenglander 6021d76
tidy
maxenglander cbd004b
Update go/vt/mysqlctl/clone.go
maxenglander b8c0027
configurable clone restart timeout
maxenglander bf13376
update tests
maxenglander c46e365
one more test case
maxenglander ceef59d
Update go/vt/mysqlctl/clone.go
maxenglander 2089cf2
improve logging
maxenglander e63dc67
trigger ci
maxenglander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth adding some context like "for use as CLONE REMOTE target" to the log messages. For the errors returned, we can/should wrap them with that context at the
CloneFromDonorcall site (there isn't one in this PR so we have to maintain that context ourselves across the PRs).