Skip to content

Add test coverage for dropTargetShards function #19086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivansh-gohem wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add test coverage for dropTargetShards function #19086

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2fd8bf
Add test coverage for dropTargetShards function
shivansh-gohem Dec 25, 2025
dd982a3
Add state verification to TestDropTargetShards_NoOp
shivansh-gohem Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions go/vt/vtctl/workflow/traffic_switcher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,3 +450,36 @@ func TestCancelMigration_SHARDS(t *testing.T) {
assert.Empty(t, env.tmc.vrQueries[100])
assert.Empty(t, env.tmc.vrQueries[200])
}


func TestDropTargetShards_NoOp(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
defer cancel()

workflowName := "wf1"
tableName := "t1"
sourceKeyspace := &testKeyspace{KeyspaceName: "sourceks", ShardNames: []string{"0"}}
targetKeyspace := &testKeyspace{KeyspaceName: "targetks", ShardNames: []string{"0"}}

schema := map[string]*tabletmanagerdatapb.SchemaDefinition{
tableName: {
TableDefinitions: []*tabletmanagerdatapb.TableDefinition{
{
Name: tableName,
Schema: fmt.Sprintf("CREATE TABLE %s (id BIGINT, name VARCHAR(64), PRIMARY KEY (id))", tableName),
},
},
},
}

env := newTestEnv(t, ctx, defaultCellName, sourceKeyspace, targetKeyspace)
defer env.close()
env.tmc.schema = schema

ts, _, err := env.ws.getWorkflowState(ctx, targetKeyspace.KeyspaceName, workflowName)
require.NoError(t, err)

// Verify dropTargetShards can be called safely
err = ts.dropTargetShards(ctx)
require.NoError(t, err)
Copy link
Member

@mattlord mattlord Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivansh-gohem This may improve the test coverage number, but I don't see how it adds any actual testing value? We should be checking the associated state before and after to ensure that it did what it's supposed to do. Can you please add that?

}