Skip to content

Conversation

@mcpherrinm
Copy link
Contributor

@mcpherrinm mcpherrinm commented Dec 30, 2025

Description

The tracingService interface has methods New and NewFromString that are called by trace.NewSpan and trace.NewFromString.

trace.NewSpan and trace.NewFromString take and return a context.
That matches what OpenTelemetry's API wants, but doesn't match the tracingService interface they call.

By making the tracingService methods use contexts, it'll be much easier to add OpenTelemetry for #17341 as the APIs are aligned.

Related Issue(s)

fixes #19125

blocked on #19092
blocks #17341

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

This should have no functional changes, though I don't know if anyone is depending on these public interfaces outside of the Vitess codebase.

AI Disclosure

No AI written code, though some AI use while implementing this interface for OpenTelemetry is what motivated the change.

@github-actions github-actions bot added this to the v24.0.0 milestone Dec 30, 2025
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 30, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 30, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mcpherrinm mcpherrinm force-pushed the mattm-new-span-context branch from 6968344 to 9918597 Compare December 30, 2025 04:21
@mcpherrinm mcpherrinm mentioned this pull request Dec 30, 2025
5 tasks
New and NewFromString in the tracingService interface are called by
trace.NewSpan and trace.NewFromString, who take and return a context.

This aligns them, so the plugin matches their caller.

This makes the interface more compatible with OpenTelemetry API, making it
easier to write an upcoming tracing plugin using that API.

Signed-off-by: Matthew McPherrin <[email protected]>
@mcpherrinm mcpherrinm force-pushed the mattm-new-span-context branch from 9918597 to 9f7ce81 Compare January 12, 2026 16:56
@mcpherrinm mcpherrinm marked this pull request as ready for review January 12, 2026 17:03
Signed-off-by: Matthew McPherrin <[email protected]>
@mcpherrinm mcpherrinm force-pushed the mattm-new-span-context branch from eea0f0d to 9de286e Compare January 13, 2026 04:41
@mcpherrinm
Copy link
Contributor Author

I've looked at the CI failures and they don't seem related. Flakes?

(Except pull request labels, which I don't have permission to set)

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.88%. Comparing base (fa770f9) to head (9de286e).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
go/trace/opentracing.go 44.44% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19093   +/-   ##
=======================================
  Coverage   69.87%   69.88%           
=======================================
  Files        1613     1613           
  Lines      216002   216020   +18     
=======================================
+ Hits       150939   150968   +29     
+ Misses      65063    65052   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change tracingService methods to use contexts

1 participant