-
Notifications
You must be signed in to change notification settings - Fork 224
docs: Document QueryThrottler metrics #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Stuti Biyani <[email protected]>
|
@Promptless please make sure that this is still up to date with the PR |
|
Promptless escalated the following message to you. If you respond, please remember to tag Promptless: Hi @mattlord! I've reviewed the documentation against the current state of PR #18740, and I can confirm that the documentation is still accurate and up to date. The documentation correctly covers all 4 metrics introduced in the PR:
All metric names, labels, and descriptions match the implementation. No changes are needed. |
|
Let's come back to this once #2046 is merged... |
|
@Promptless can you please merge in origin/prod and update this PR now that #2046 has been merged? |
|
Promptless escalated the following message to you. If you respond, please remember to tag Promptless: @mattlord I've merged in |
|
I've added new changes to address this PR comment in commit ec1aaf1 |
ec1aaf1 to
e4a6f51
Compare
Signed-off-by: Matt Lord <[email protected]>
…uery-throttler-metrics
475e17a to
b885eb1
Compare
Signed-off-by: Matt Lord <[email protected]>
b885eb1 to
ed6fd17
Compare
|
Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.) |
|
@stutibiyani can you please review again? Once you approve, then I will merge it. Thanks! ❤️ |
Added documentation for the new QueryThrottler metrics introduced in PR #18740. The QueryThrottler evaluates queries to determine if they should be throttled based on configurable strategies. This documentation covers 4 new metrics (QueryThrottlerRequests, QueryThrottlerThrottled, QueryThrottlerTotalLatencyNs, QueryThrottlerEvaluateLatencyNs) with detailed label descriptions to help operators monitor throttling behavior.
Open this suggestion in the Promptless dashboard
Preview: https://deploy-preview-2031--vitess.netlify.app/docs/24.0/reference/query-serving/metrics/
Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.
If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)