Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented Dec 1, 2025

Added documentation for the new QueryThrottler metrics introduced in PR #18740. The QueryThrottler evaluates queries to determine if they should be throttled based on configurable strategies. This documentation covers 4 new metrics (QueryThrottlerRequests, QueryThrottlerThrottled, QueryThrottlerTotalLatencyNs, QueryThrottlerEvaluateLatencyNs) with detailed label descriptions to help operators monitor throttling behavior.

Open this suggestion in the Promptless dashboard

Preview: https://deploy-preview-2031--vitess.netlify.app/docs/24.0/reference/query-serving/metrics/


Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.

If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit ed6fd17
🔍 Latest deploy log https://app.netlify.com/projects/vitess/deploys/694418391afa730008ad2faa
😎 Deploy Preview https://deploy-preview-2031--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mattlord mattlord self-requested a review December 15, 2025 14:32
@mattlord mattlord marked this pull request as ready for review December 15, 2025 16:47
@mattlord
Copy link
Member

@Promptless please make sure that this is still up to date with the PR

@promptless
Copy link
Contributor Author

promptless bot commented Dec 15, 2025

Promptless escalated the following message to you. If you respond, please remember to tag Promptless:

Hi @mattlord! I've reviewed the documentation against the current state of PR #18740, and I can confirm that the documentation is still accurate and up to date.

The documentation correctly covers all 4 metrics introduced in the PR:

  • QueryThrottlerRequests - with labels Strategy, Workload, Priority
  • QueryThrottlerThrottled - with labels Strategy, Workload, Priority, MetricName, MetricValue, DryRun
  • QueryThrottlerTotalLatencyNs - with labels Strategy, Workload, Priority
  • QueryThrottlerEvaluateLatencyNs - with labels Strategy, Workload, Priority

All metric names, labels, and descriptions match the implementation. No changes are needed.

@mattlord
Copy link
Member

Let's come back to this once #2046 is merged...

@mattlord
Copy link
Member

@Promptless can you please merge in origin/prod and update this PR now that #2046 has been merged?

@promptless
Copy link
Contributor Author

promptless bot commented Dec 18, 2025

Promptless escalated the following message to you. If you respond, please remember to tag Promptless:

@mattlord I've merged in prod and updated the PR. The merge completed successfully with no conflicts. The QueryThrottler metrics documentation is still accurate and up to date. The PR now includes all the recent changes from prod, including PR #2046.

@promptless
Copy link
Contributor Author

promptless bot commented Dec 18, 2025

I've added new changes to address this PR comment in commit ec1aaf1

@mattlord mattlord force-pushed the promptless/document-query-throttler-metrics branch from ec1aaf1 to e4a6f51 Compare December 18, 2025 14:52
@mattlord mattlord force-pushed the promptless/document-query-throttler-metrics branch from 475e17a to b885eb1 Compare December 18, 2025 15:04
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the promptless/document-query-throttler-metrics branch from b885eb1 to ed6fd17 Compare December 18, 2025 15:05
@promptless
Copy link
Contributor Author

promptless bot commented Dec 18, 2025

Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)

@mattlord mattlord requested a review from stutibiyani December 18, 2025 15:09
@mattlord
Copy link
Member

@stutibiyani can you please review again? Once you approve, then I will merge it. Thanks! ❤️

@mattlord mattlord merged commit e7204a7 into prod Dec 22, 2025
5 checks passed
@mattlord mattlord deleted the promptless/document-query-throttler-metrics branch December 22, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants