Removed the default 'http://evil.com' Origin override in the request. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with a comment on how to enable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #45 .
At my work, we use the
Originheader to try and guess whether a full request/response is occurring over https or not. More generally, I think it's common to log non-sensitive headers for threat monitoring/analytics etc. For anyone not familiar with this extension, a large number of incoming requests from 'evil.com' can be very alarming!That said, I left the ability as a comment with how to enable - if people want to change the request origin, they should feel free to. But I don't think that should be happening for devs unknowingly. :)
@vitvad , there hasn't been much activity in this repo lately but I'd love if you could merge this in and get an update into the extension store (my understanding is existing users should get autoupdated?). Let me know if there's anything you'd need from me to make that easier. 🍻