Add relative locator type for web elements #5468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkepin
commented
Oct 28, 2024
| import java.util.regex.Pattern; | ||
| import java.util.stream.Stream; | ||
|
|
||
| public final class RelativeLocatorUtils |
vkepin
commented
Oct 28, 2024
|
|
||
| for (Map.Entry<String, String> relativeLocator : getRelativeLocators(relativePart).entrySet()) | ||
| { | ||
| RelativeElementPosition relativeElementPosition = findRelativePosition(relativeLocator.getValue()); |
uarlouski
reviewed
Oct 29, 2024
| public By buildBy(String value) | ||
| { | ||
| By relativeLocator = RelativeLocatorUtils.convertRelativeStringToBy(value); | ||
| return By.xpath("./div"); |
vkepin
commented
Nov 14, 2024
| Then number of elements found by `id(block2)` is = `1` | ||
| Then number of elements found by `relative(id(block1)>>toRightOf(id(block2)))` is = `0` | ||
|
|
||
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5468 +/- ##
============================================
+ Coverage 97.69% 97.71% +0.01%
- Complexity 7312 7350 +38
============================================
Files 984 986 +2
Lines 20536 20668 +132
Branches 1344 1361 +17
============================================
+ Hits 20062 20195 +133
Misses 362 362
+ Partials 112 111 -1 ☔ View full report in Codecov by Sentry. |
vkepin
force-pushed
the
relative_locators
branch
3 times, most recently
from
6eeb495 to
b2d641f
Compare
valfirst
requested changes
Nov 27, 2024
| |Locates elements matching xpath `//div` and placed *to the left of* relative element with id = right_block | ||
|
|
||
| |`toRightOf` | ||
| |relative(xpath(//div)>>toLeftOf(id(left_block))) |
There was a problem hiding this comment.
Suggested change
| |relative(xpath(//div)>>toLeftOf(id(left_block))) | |
| |relative(xpath(//div)>>toRightOf(id(right_block))) |
|
|
||
| |`nearXpx` | ||
| |relative(xpath(//div)>>near200px(id(distant_block))) | ||
| |Provide possibility to configure max distance between near elements |
There was a problem hiding this comment.
follow the same to describe examples
| </property> | ||
| <property name="baseValidations"> | ||
| <bean class="org.vividus.steps.ui.validation.BaseValidations" /> | ||
| </property> |
There was a problem hiding this comment.
use constructor-based injection
vkepin
force-pushed
the
relative_locators
branch
from
21c234e to
44aa819
Compare
vkepin
force-pushed
the
relative_locators
branch
from
44aa819 to
0d11047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.