feat: allow writing custom text to stdin on button press #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than expecting external programs to handle 1, 2, and 3 on their standard input, this allows the user to configure the text sent themselves. This is particularly relevant for my tool, painted, which serves as a notification daemon and takes commands to manage the notif queue over stdin. With this patch, a config like the following works just as one would expect: [notifs] command=painted interval=persist btn_left_cmd=clear btn_right_cmd=expand Note this only applies to bars with the persist interval, as one would expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small feature that I'll be using for my setup and notification daemon; you can merge it if you'd like :) Let me know if there's anything more to be done.
Here's the commit message explaining the change:
Rather than expecting external programs to handle 1, 2, and 3 on their standard input, this allows the user to configure the text sent themselves.
This is particularly relevant for my tool, painted, which serves as a notification daemon and takes commands to manage the notif queue over stdin. With this patch, a config like the following works just as one would expect:
Note this only applies to bars with the persist interval, as one would expect.