feat: dropUnknownIndexes #11

RahulLanjewar93 · 2025-09-09T09:11:25Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: FILL_THIS_OUT

Approach

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)
Add security check
Add new Parse Error codes to Parse JS SDK

…, `22.12.0` (parse-community#9521) BREAKING CHANGE: This releases increases the required minimum Node versions to 18.20.4, 20.18.0, 22.12.0 and removes unofficial support for Node 19.

# [8.0.0-alpha.1](parse-community/parse-server@7.4.0-alpha.7...8.0.0-alpha.1) (2025-01-11) ### Features * Increase required minimum Node versions to `18.20.4`, `20.18.0`, `22.12.0` ([parse-community#9521](parse-community#9521)) ([4e151cd](parse-community@4e151cd)) ### BREAKING CHANGES * This releases increases the required minimum Node versions to 18.20.4, 20.18.0, 22.12.0 and removes unofficial support for Node 19. ([4e151cd](4e151cd))

…unity#9524)

# [8.0.0-alpha.2](parse-community/parse-server@8.0.0-alpha.1...8.0.0-alpha.2) (2025-01-11) ### Bug Fixes * Push adapter not loading on some versions of Node 22 ([parse-community#9524](parse-community#9524)) ([ff7f671](parse-community@ff7f671))

…`, `8.0.4` (parse-community#9531) BREAKING CHANGE: This releases increases the required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` and removes support for MongoDB `4`, `5`.

# [8.0.0-alpha.3](parse-community/parse-server@8.0.0-alpha.2...8.0.0-alpha.3) (2025-01-12) ### Features * Increase required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` ([parse-community#9531](parse-community#9531)) ([871e508](parse-community@871e508)) ### BREAKING CHANGES * This releases increases the required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` and removes support for MongoDB `4`, `5`. ([871e508](871e508))

…mmunity#9526)

# [8.0.0-alpha.4](parse-community/parse-server@8.0.0-alpha.3...8.0.0-alpha.4) (2025-01-12) ### Features * Deprecate `PublicAPIRouter` in favor of `PagesRouter` ([parse-community#9526](parse-community#9526)) ([7f66629](parse-community@7f66629))

…nCloudFunction` to `true` (parse-community#9527) BREAKING CHANGE: The default value of Parse Server option `encodeParseObjectInCloudFunction` changes to `true`; the option has been deprecated and will be removed in a future version.

# [8.0.0-alpha.5](parse-community/parse-server@8.0.0-alpha.4...8.0.0-alpha.5) (2025-01-12) ### Features * Change default value of Parse Server option `encodeParseObjectInCloudFunction` to `true` ([parse-community#9527](parse-community#9527)) ([5c5ad69](parse-community@5c5ad69)) ### BREAKING CHANGES * The default value of Parse Server option `encodeParseObjectInCloudFunction` changes to `true`; the option has been deprecated and will be removed in a future version. ([5c5ad69](5c5ad69))

….3` (parse-community#9538) BREAKING CHANGE: This releases increases the required minimum versions to Postgres `15`, PostGIS `3.3` and removes support for Postgres `13`, `14`, PostGIS `3.1`, `3.2`.

# [8.0.0-alpha.6](parse-community/parse-server@8.0.0-alpha.5...8.0.0-alpha.6) (2025-01-12) ### Features * Increase required minimum versions to Postgres `15`, PostGIS `3.3` ([parse-community#9538](parse-community#9538)) ([89c9b54](parse-community@89c9b54)) ### BREAKING CHANGES * This releases increases the required minimum versions to Postgres `15`, PostGIS `3.3` and removes support for Postgres `13`, `14`, PostGIS `3.1`, `3.2`. ([89c9b54](89c9b54))

…to 14.0.3 (parse-community#9540)

…y#9539)

…ommunity#9542)

parse-community#9543)

…9549)

…unity#9552)

…9561)

…o 7.26.5 (parse-community#9562)

…9569)

…connectTimeoutMS`, `socketTimeoutMS` (parse-community#9522)

## [8.2.2](parse-community/parse-server@8.2.1...8.2.2) (2025-07-10) ### Bug Fixes * Data schema exposed via GraphQL API public introspection (GHSA-48q3-prgv-gm4w) ([parse-community#9819](parse-community#9819)) ([c58b2eb](parse-community@c58b2eb))

…eturns no results (parse-community#9822)

## [8.2.3-alpha.1](parse-community/parse-server@8.2.2...8.2.3-alpha.1) (2025-07-13) ### Bug Fixes * MongoDB aggregation pipeline with `$dateSubtract` from `$$NOW` returns no results ([parse-community#9822](parse-community#9822)) ([847a274](parse-community@847a274))

…#9825)

…nity#9824)

…ommunity#9835)

## [8.2.3](parse-community/parse-server@8.2.2...8.2.3) (2025-08-01) ### Bug Fixes * MongoDB aggregation pipeline with `$dateSubtract` from `$$NOW` returns no results ([parse-community#9822](parse-community#9822)) ([847a274](parse-community@847a274))

…9829)

## [8.2.4-alpha.1](parse-community/parse-server@8.2.3...8.2.4-alpha.1) (2025-08-02) ### Bug Fixes * Security upgrade form-data from 4.0.3 to 4.0.4 ([parse-community#9829](parse-community#9829)) ([c2c593f](parse-community@c2c593f))

…y#9834)

## [8.2.4](parse-community/parse-server@8.2.3...8.2.4) (2025-09-01) ### Bug Fixes * Security upgrade form-data from 4.0.3 to 4.0.4 ([parse-community#9829](parse-community#9829)) ([c2c593f](parse-community@c2c593f))

…#9854)

gemini-code-assist

Summary of Changes

Hello @RahulLanjewar93, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Parse Server's schema migration capabilities by introducing a new configuration setting. This change provides greater flexibility for developers who manage database indexes manually, preventing the server from automatically removing indexes that are intentionally kept outside of the defined schema.

Highlights

New Configuration Option: Introduced a new boolean configuration option, dropUnknownIndexes, within Parse Server's schema options.
Control Over Index Deletion: This new option allows users to control whether Parse Server automatically drops database indexes that are not explicitly defined in the application's schema.
Default Behavior Maintained: The default value for dropUnknownIndexes is true, meaning the existing behavior of dropping unknown indexes remains unchanged unless explicitly set to false.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new dropUnknownIndexes option to control schema migrations. While the feature is useful, the current implementation has a few issues. The default value for the new option is not handled correctly, which could break existing behavior. There's also a bug in how modified indexes are handled when dropUnknownIndexes is false. Additionally, the tests for this new feature have incorrect descriptions, and one of them is broken. I've provided detailed feedback and suggestions to address these points.

gemini-code-assist · 2025-09-09T09:14:01Z

spec/DefinedSchemas.spec.js

    });

-    it('should delete removed indexes', async () => {
+    it('should delete removed indexes when dropUnknownIndexes is set to false', async () => {


The test description is incorrect. To delete indexes, dropUnknownIndexes should be true.

More importantly, this test will fail because it relies on the default value for dropUnknownIndexes. The default is not being set in Config.js, so it will be undefined (a falsy value). As a result, indexes will not be dropped, and the assertion expect(schema.indexes).toBeUndefined() will fail.

Please update the test to explicitly set dropUnknownIndexes: true in the schemas object and correct the description to make the test robust and clear.

Suggested change

it('should delete removed indexes when dropUnknownIndexes is set to false', async () => {

it('should delete removed indexes when dropUnknownIndexes is true', async () => {

gemini-code-assist · 2025-09-09T09:14:01Z

spec/DefinedSchemas.spec.js

      expect(schema.indexes).toBeUndefined();
    });
+
+    it('should not delete removed indexes when dropUnknownIndexes is set to true', async () => {


The test description is incorrect. The implementation correctly tests the case where dropUnknownIndexes is false to prevent deleting indexes. The description should be updated to reflect this.

Suggested change

it('should not delete removed indexes when dropUnknownIndexes is set to true', async () => {

it('should not delete removed indexes when dropUnknownIndexes is set to false', async () => {

mtrezza and others added 30 commits January 11, 2025 18:42

feat: Increase required minimum Node versions to 18.20.4, 20.18.0…

4e151cd

…, `22.12.0` (parse-community#9521) BREAKING CHANGE: This releases increases the required minimum Node versions to 18.20.4, 20.18.0, 22.12.0 and removes unofficial support for Node 19.

fix: Push adapter not loading on some versions of Node 22 (parse-comm…

ff7f671

…unity#9524)

feat: Increase required minimum MongoDB versions to 6.0.19, `7.0.16…

871e508

…`, `8.0.4` (parse-community#9531) BREAKING CHANGE: This releases increases the required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` and removes support for MongoDB `4`, `5`.

feat: Deprecate PublicAPIRouter in favor of PagesRouter (parse-co…

7f66629

…mmunity#9526)

feat: Increase required minimum versions to Postgres 15, PostGIS `3…

89c9b54

….3` (parse-community#9538) BREAKING CHANGE: This releases increases the required minimum versions to Postgres `15`, PostGIS `3.3` and removes support for Postgres `13`, `14`, PostGIS `3.1`, `3.2`.

refactor: Bump mime from 4.0.4 to 4.0.6 (parse-community#9502)

bb1daaf

refactor: Bump otpauth from 9.3.5 to 9.3.6 (parse-community#9493)

a0efad8

refactor: Bump @semantic-release/release-notes-generator from 14.0.1 …

1b61cab

…to 14.0.3 (parse-community#9540)

refactor: Bump semantic-release from 24.2.0 to 24.2.1 (parse-communit…

28b3ede

…y#9539)

refactor: Bump @graphql-tools/schema from 10.0.13 to 10.0.16 (parse-c…

ad0a7bc

…ommunity#9542)

refactor: Bump @semantic-release/commit-analyzer from 13.0.0 to 13.0.1 (

970528d

parse-community#9543)

refactor: Bump @apollo/server from 4.11.2 to 4.11.3 (parse-community#…

cdf5115

…9549)

refactor: Bump lint-staged from 15.2.11 to 15.3.0 (parse-community#9548)

59340ce

refactor: Bump @graphql-tools/merge from 9.0.14 to 9.0.17 (parse-comm…

7194ccc

…unity#9552)

test: Add test for saving file without extension (parse-community#9535)

34636be

refactor: Bump yaml from 2.6.1 to 2.7.0 (parse-community#9559)

1b8ecba

refactor: Bump @apollo/client from 3.12.3 to 3.12.6 (parse-community#…

0644f42

…9561)

refactor: Bump @babel/plugin-transform-flow-strip-types from 7.25.9 t…

0a23023

…o 7.26.5 (parse-community#9562)

refactor: Bump lint-staged from 15.3.0 to 15.4.1 (parse-community#9563)

42f785e

refactor: Bump uuid from 11.0.3 to 11.0.5 (parse-community#9568)

6181652

refactor: Bump @apollo/client from 3.12.6 to 3.12.7 (parse-community#…

5ca0aa3

…9569)

refactor: Bump @babel/core from 7.26.0 to 7.26.7 (parse-community#9572)

3b20a6f

feat: Add support for MongoDB databaseOptions keys minPoolSize, `…

91618fe

…connectTimeoutMS`, `socketTimeoutMS` (parse-community#9522)

mtrezza and others added 19 commits July 10, 2025 04:41

build: Release (parse-community#9821)

3b8b3cb

chore(release): 8.2.2 [skip ci]

e3f5ae0

## [8.2.2](parse-community/parse-server@8.2.1...8.2.2) (2025-07-10) ### Bug Fixes * Data schema exposed via GraphQL API public introspection (GHSA-48q3-prgv-gm4w) ([parse-community#9819](parse-community#9819)) ([c58b2eb](parse-community@c58b2eb))

fix: MongoDB aggregation pipeline with $dateSubtract from $$NOW r…

847a274

…eturns no results (parse-community#9822)

refactor: Upgrade pg-promise from 11.13.0 to 11.14.0 (parse-community…

dfffc14

…#9825)

refactor: Upgrade express-rate-limit from 7.5.0 to 7.5.1 (parse-commu…

4e301a5

…nity#9824)

refactor: Upgrade @babel/eslint-parser from 7.27.1 to 7.28.0 (parse-c…

3d8dc5f

…ommunity#9835)

empty commit to trigger CI

a09f751

build: Release (parse-community#9836)

080610a

fix: Security upgrade form-data from 4.0.3 to 4.0.4 (parse-community#…

c2c593f

…9829)

chore(release): 8.2.4-alpha.1 [skip ci]

7434847

## [8.2.4-alpha.1](parse-community/parse-server@8.2.3...8.2.4-alpha.1) (2025-08-02) ### Bug Fixes * Security upgrade form-data from 4.0.3 to 4.0.4 ([parse-community#9829](parse-community#9829)) ([c2c593f](parse-community@c2c593f))

refactor: Bump @eslint/plugin-kit from 0.3.1 to 0.3.4 (parse-communit…

587abdd

…y#9834)

refactor: Bump sha.js from 2.4.11 to 2.4.12 (parse-community#9845)

4b3f10b

empty commit to trigger CI

b71a310

build: Release (parse-community#9851)

e6283c3

chore(release): 8.2.4 [skip ci]

43cb65f

## [8.2.4](parse-community/parse-server@8.2.3...8.2.4) (2025-09-01) ### Bug Fixes * Security upgrade form-data from 4.0.3 to 4.0.4 ([parse-community#9829](parse-community#9829)) ([c2c593f](parse-community@c2c593f))

refactor: Bump brace-expansion from 1.1.11 to 1.1.12 (parse-community…

82fdb0d

…#9854)

feat: dropUnknownIndexes

cd3c33d

RahulLanjewar93 requested review from PawanKumar0, hariprasadiit and nikhilcares22 September 9, 2025 09:11

RahulLanjewar93 self-assigned this Sep 9, 2025

RahulLanjewar93 changed the base branch from alpha to 7-vizmo September 9, 2025 09:11

gemini-code-assist bot reviewed Sep 9, 2025

View reviewed changes

fix: minor fix

847b51c

gemini-code-assist bot reviewed Sep 9, 2025

View reviewed changes

RahulLanjewar93 and others added 2 commits September 9, 2025 14:46

fix: ran definitions

de436f0

Merge branch 'alpha' into feat-dropUnknownIndexes

84cf02c

RahulLanjewar93 closed this Sep 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: dropUnknownIndexes #11

feat: dropUnknownIndexes #11

Uh oh!

RahulLanjewar93 commented Sep 9, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 9, 2025

Uh oh!

gemini-code-assist bot Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

	it('should delete removed indexes when dropUnknownIndexes is set to false', async () => {
	it('should delete removed indexes when dropUnknownIndexes is true', async () => {

	it('should not delete removed indexes when dropUnknownIndexes is set to true', async () => {
	it('should not delete removed indexes when dropUnknownIndexes is set to false', async () => {

feat: dropUnknownIndexes #11

feat: dropUnknownIndexes #11

Uh oh!

Conversation

RahulLanjewar93 commented Sep 9, 2025

Pull Request

Issue

Approach

Tasks

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants