Reset means reset + set doesn't reset

vizzuhq · Nov 18, 2024 · 3514412 · 3514412
1 parent 1eb6d02
commit 3514412
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/src/chart/options/channel.cpp b/src/chart/options/channel.cpp
@@ -151,6 +151,7 @@ void Channel::reset()
 	set = {};
 	labelLevel = {};
 	title = {};
+	range = {};
 }
 
 bool Channel::isEmpty() const

diff --git a/src/chart/options/config.cpp b/src/chart/options/config.cpp
@@ -89,29 +89,25 @@ void Config::setChannelParam(const std::string &path,
 
 	if (property == "set") {
 		if (parts.size() == 3) {
-			channel.reset();
+			channel.set = {};
 			options.markersInfo.clear();
 			return;
 		}
 
-		if (auto &listParser = ChannelSeriesList::Parser::instance();
-		    parts.size() == 4) {
+		auto &listParser = ChannelSeriesList::Parser::instance();
+		if (parts.size() == 4) {
 			if (parts[3] == "begin") {
-				if (parts[2] == "set") channel.reset();
-
+				if (parts[2] == "set") channel.set = {};
 				options.markersInfo.clear();
 				listParser.table = &table.get();
 				listParser.channels.resize(std::stoull(value));
 				return;
 			}
-
 			listParser.current = std::nullopt;
-			listParser.path = parts;
 		}
-		else {
+		else
 			listParser.current = std::stoull(parts.at(3));
-			listParser.path = parts;
-		}
+		listParser.path = parts;
 	}
 
 	if (property == "range") property += "." + parts.at(3);

diff --git a/test/e2e/tests/config_tests/dimension_axis_title.mjs b/test/e2e/tests/config_tests/dimension_axis_title.mjs
@@ -26,7 +26,7 @@ const testSteps = [
 	(chart) =>
 		chart.animate({
 			x: { set: 'Baz' },
-			size: { set: 'Baz' }
+			size: { set: 'Baz', title: 'Bigness' }
 		})
 ]