Data series descriptor on TS API changed from formatted string to obj… #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simzer
force-pushed
the
dataseries-object
branch
from
6db9e4b to
d58ca60
Compare
simzer
force-pushed
the
dataseries-object
branch
from
d58ca60 to
c8cd17a
Compare
dovicsin
approved these changes
Feb 14, 2024
Comment on lines
+246
to
+249
| else | ||
| return seriesList.map((seriesDescriptor) => | ||
| this._normalizeSeriesDescriptor(seriesDescriptor) | ||
| ) |
There was a problem hiding this comment.
Only semantic: if the condition is formatted over several lines, it is not usual to leave out the brackets.
There was a problem hiding this comment.
Köszi, ezt most igy hagyom, mert a libben a kód formázást a prettierrel csináljuk, ott kellene majd beállítani rule-t erre.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect.