Add Basic Share Button#212
Merged
Merged
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vkoves
commented
Aug 17, 2025
| import { Component, Prop, Vue } from 'vue-property-decorator'; | ||
|
|
||
| /** | ||
| * Reusable share button that uses the native Web Share API when available, |
Owner
Author
There was a problem hiding this comment.
I started this in page, but realized we could use this component anywhere!
vkoves
commented
Aug 17, 2025
| // using the device's native sharing mechanisms (e.g., share sheet on mobile devices) | ||
| // Supported on most modern mobile browsers and some desktop browsers | ||
| window.navigator | ||
| .share({ |
Owner
Author
There was a problem hiding this comment.
I hadn't heard of this API before - it doesn't do anything on desktop, but it's very cool on mobile!
JonHunt1995
requested review from
JonHunt1995
and removed request for
JonHunt1995
Collaborator
|
Gave this a shot on Firefox and my Samsung Galaxy A54 5G - worked great! No notes! |
JonHunt1995
reviewed
Aug 20, 2025
JonHunt1995
left a comment
JonHunt1995
left a comment
Collaborator
There was a problem hiding this comment.
Looks good so far. The Web Share API integration is nice! I will try out on mobile and desktop before approving.
JonHunt1995
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a basic share button, which copies the link to the current page to your clipboard on desktop, and opens a share menu on mobile (which should prompt for things like social media, email, etc).
A start to issue #203
Testing Instructions
Tested on mobile, and confirmed the native share menu shows up, and that if I share, it'll use our sharing text.
Checklist: