-
-
Notifications
You must be signed in to change notification settings - Fork 308
Bevy 0.18 #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bevy 0.18 #452
Conversation
|
|
||
| // Run the subgraph on the Egui view. | ||
| graph.run_sub_graph(SubGraphEgui, vec![], Some(default_camera_view.0))?; | ||
| graph.run_sub_graph(SubGraphEgui, vec![], Some(default_camera_view.0), None)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure on the purpose of the debug_group parameter, so defaulted to none 🤷
| bevy_camera = { version = "0.18.0-rc.1" } | ||
| bevy_derive = { version = "0.18.0-rc.1" } | ||
| bevy_ecs = { version = "0.18.0-rc.1" } | ||
| bevy_input = { version = "0.18.0-rc.1", features = ["gamepad"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an issue on the Bevy end that the import isn't feature-gated:
error[E0432]: unresolved import `bevy_input::gamepad`
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_input_focus-0.18.0-rc.1/src/lib.rs:37:18
|
37 | use bevy_input::{gamepad::GamepadButtonChangedEvent, keyboard::KeyboardInput, mouse::MouseWheel};
| ^^^^^^^ could not find `gamepad` in `bevy_input`
|
note: found an item that was configured out
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_input-0.18.0-rc.1/src/lib.rs:26:9
|
25 | #[cfg(feature = "gamepad")]
| ------------------- the item is gated behind the `gamepad` feature
26 | pub mod gamepad;
| ^^^^^^^
Aaaand it's already fixed here: bevyengine/bevy#22177
So let's remove the gamepad feature requirement once the next version is available.
Updates for bevy 0.18 (rc currently).
Mainly renames and module re-organisation. The only non completely trivial change is the bind group layout changes as per: bind-group-layout-descriptors.md.
Also includes a workaround for the current lack of bindless support on Metal backends, happy to split this out into a separate PR if desired?
See for details: