forked from Hacker0x01/react-datepicker
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Solution to issue Hacker0x01#1337 (Hacker0x01#1541)
* Added a prop and logic for keeping the currently displayed months the same when working with a multi-month inline calendar. * Added tests to prove the added functionality. * Removed the boolean value that caused the Travis CI build to fail. * Removed duplicate default props from calendar.jsx. * Fixed a test that fails when it is December so it will no longer fail for the entirety of the month.
- Loading branch information
1 parent
20bd487
commit 23a0c99
Showing
33 changed files
with
35,611 additions
and
7,733 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,21 @@ | ||
# How to contribute | ||
|
||
Thanks for taking your time to read this. We're thrilled you're reading this because we the help from the community to keep improving this project. | ||
|
||
## Testing | ||
|
||
We have a handful of Cucumber features, but most of our testbed consists of RSpec examples. Please write RSpec examples for new code you create. | ||
|
||
## Submitting changes | ||
|
||
Please send a [GitHub Pull Request](https://github.com/Hacker0x01/react-datepicker/pull/new/master) with a clear list of what you've done (read more about [pull requests](https://help.github.com/articles/about-pull-requests/)). When you send a pull request, we will love you forever if you include a test to cover your changes. We can always use more test coverage. | ||
Always write a clear log message for your commits. One-line messages are fine for small changes, but bigger changes should look like this: | ||
$ git commit -m "A summary of the commit | ||
> | ||
> A paragraph describing what changed and its impact." | ||
$ git commit -m "A summary of the commit > > A paragraph describing what changed and its impact." | ||
|
||
## Coding conventions | ||
|
||
Start reading our code, and you'll get the hang of it. We optimize for readability: | ||
* We use prettier for code styling. Don't worry about tabs vs spaces, or how to indent your code. | ||
* We use ESlint for all other coding standards. We try to be consistent and helpful. | ||
* This is open source software. Consider the people who will read your code, and make it look nice for them. It's sort of like driving a car: Perhaps you love doing donuts when you're alone, but with passengers, the goal is to make the ride as smooth as possible. | ||
|
||
- We use prettier for code styling. Don't worry about tabs vs spaces, or how to indent your code. | ||
- We use ESlint for all other coding standards. We try to be consistent and helpful. | ||
- This is open source software. Consider the people who will read your code, and make it look nice for them. It's sort of like driving a car: Perhaps you love doing donuts when you're alone, but with passengers, the goal is to make the ride as smooth as possible. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.