Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Forks filtering #16

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

t0mmili
Copy link
Contributor

@t0mmili t0mmili commented Oct 13, 2024

  1. New env var GHS_FILTER_FORKS.
  2. Tests for new functionality.

@vladkens
Copy link
Owner

Hi, @t0mmili. Thanks for the PR. This is a useful functionality. The only thing I'm not sure about is a separate environment for configuration (because there's also archive and private flags). I was also thinking about additional rules when working on filtering, but haven't figured out the syntax yet. What do you think about this format:

GHS_FILTER=vladkens/*,!fork,!private,!archive

If it looks okay I can update your PR with this rules.

@t0mmili
Copy link
Contributor Author

t0mmili commented Oct 18, 2024

@vladkens, that was actually my initial idea to use !fork 😆 Personally it felt odd and confusing at first, from the user perspective. But on the other hand, maybe it makes more sense to keep filtering in one var. Go ahead and update the PR. Thanks!

@vladkens vladkens merged commit ca3a6fc into vladkens:main Oct 21, 2024
1 check passed
@vladkens vladkens mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants