-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x.json2.decoder2: use json_str and json_len, intead of just json #22704
Open
enghitalo
wants to merge
8
commits into
vlang:master
Choose a base branch
from
enghitalo:x.json2.decoder.json2.Any
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+288
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Oct 30, 2024
spytheman
reviewed
Oct 30, 2024
spytheman
reviewed
Oct 30, 2024
@spytheman I'm in an appointment. I think I'll be able to make the changes tomorrow. |
enghitalo
changed the title
perf: use json_str and json_len, intead of just json
x.json2.decoder2: use json_str and json_len, intead of just json
Nov 1, 2024
ttytm
reviewed
Nov 1, 2024
spytheman
reviewed
Nov 2, 2024
…ite and is a bit less expressive (checking the `len` is not exclusive to strings; while it is fairly clear in this context, in others it can create more mental overhead to grasp what is happening when reading the code) using `== ` has become something that v vet recommends to check for an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to decode part of a string without need to create a substring
Benchmark
Valgrind
./../../../../../v wipe-cache && ./../../../../../v -prod bench.v -gc none -o b_out && valgrind -s ./b_out
Before
After