New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto.ecdsa: migrate new_key_from_seed to use high opaque #23876

Merged

spytheman merged 2 commits into vlang:master from blackshirt:ecdsa_migrate

Mar 7, 2025

+207 −80

Contributor

blackshirt commented Mar 7, 2025 •

edited

Loading

This PR migrates mostly for new_key_from_seed function to use high level EVP_PKEY opaque. Its also migrates equality check on PrivateKey and PublicKey.

Its also adding some helpers to simplify the logic
Adds some required definition

There are some bits thats not fully migrated, like the .bytes() methods on the both, maybe its ready on the next PR.
After that, we can clean its up to remove the obsoleted bits from the module.

Thanks

.


          crypto.ecdsa: migrate new_key_from_seed to use high opaque

132e3ba

huly-for-github bot commented Mar 7, 2025

Connected to Huly®: V_0.6-22279

Member

spytheman commented Mar 7, 2025 •

edited

Loading

why?
edit: answered on Discord

spytheman reviewed

View reviewed changes

vlib/crypto/ecdsa/ecdsa.v Outdated Show resolved Hide resolved

spytheman reviewed

View reviewed changes

vlib/crypto/ecdsa/ecdsa.c.v Outdated Show resolved Hide resolved

spytheman reviewed

View reviewed changes

vlib/crypto/ecdsa/ecdsa.c.v Outdated Show resolved Hide resolved

spytheman reviewed

View reviewed changes

vlib/crypto/ecdsa/ecdsa.v Outdated Show resolved Hide resolved

spytheman reviewed

View reviewed changes

vlib/crypto/ecdsa/ecdsa.v Outdated Show resolved Hide resolved


          Removes unused constants and changes to use c'group' for C-style thing

dec3391

spytheman approved these changes

View reviewed changes

Member

spytheman left a comment

Excellent work.

spytheman merged commit bc3fc12 into vlang:master

68 checks passed

blackshirt deleted the ecdsa_migrate branch

March 8, 2025 00:19

blackshirt mentioned this pull request

crypto.ecdsa: the last bits of migration steps #23877

Merged

spytheman pushed a commit that referenced this pull request


          crypto.ecdsa: complete the migration to the newer OpenSSL APIs (follo…

ec0b70e

…w up to #23876) (#23877)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet