fix: use GET query params for You.com search - #203
Merged
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
requested review from
bbrowning,
jiahuei,
leseb,
maralbahari,
noobHappylife,
qandrew and
tjtanaa
as code owners
August 24, 2026 18:12
There was a problem hiding this comment.
Pull request overview
Switches You.com search requests to GET query parameters while preserving authentication.
Changes:
- Replaces POST JSON requests with GET query serialization.
- Updates integration mocks and assertions for GET requests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/agentic-server-core/src/tool/web_search.rs |
Sends You.com searches using GET query parameters. |
crates/agentic-server-core/tests/web_search_tool_test.rs |
Updates mocks and tests for GET requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| .client | ||
| .post(url) | ||
| .get(format!("{base_url}/v1/search")) | ||
| .query(&request) |
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
force-pushed
the
codex/fix-you-search-get
branch
from
August 24, 2026 18:37
d1eb88d to
7dc9a38
Compare
franciscojavierarceo
added a commit
that referenced
this pull request
Aug 25, 2026
## Summary - align the remaining You.com test mocks with the GET query-parameter contract introduced in #203 - bound mock request captures so future contract mismatches fail within five seconds instead of hanging CI - verify the intentional 500 search mock is actually reached and cap the Rust job at 30 minutes ## Test Plan - cargo fmt --all -- --check - cargo clippy --all-targets -- -D warnings - cargo build - cargo test - cargo test -p agentic-server-core --test dispatch_loop_cassette_test - cargo test -p agentic-server-core --test messages_loop_test - cargo test -p agentic-server-core --test messages_stream_test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
No space left on device