Skip to content

[BugFix] Multi-gpu temp bug fix #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BugFix] Multi-gpu temp bug fix #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/llmcompressor/transformers/finetune/test_finetune_no_recipe_custom_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def create_mock_file(self, extension, content, path, filename):

def tearDown(self):
shutil.rmtree(self.output)
self.monkeypatch.undo()


@pytest.mark.integration
Expand All @@ -120,8 +121,11 @@ class TestOneshotCustomDatasetSmall(TestFinetuneNoRecipeCustomDataset):
def setUp(self):
import torch

self.monkeypatch = pytest.MonkeyPatch()

if torch.cuda.is_available():
self.device = "cuda:0"
self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")
else:
self.device = "cpu"

Expand All @@ -143,8 +147,10 @@ def setUp(self):
import torch
from transformers import AutoModelForCausalLM

self.monkeypatch = pytest.MonkeyPatch()
self.device = "cuda:0"
self.output = "./oneshot_output"
self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")

self.model = AutoModelForCausalLM.from_pretrained(
self.model, device_map=self.device, torch_dtype=torch.bfloat16
Expand Down
3 changes: 3 additions & 0 deletions tests/llmcompressor/transformers/finetune/test_finetune_without_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ class TestFinetuneWithoutRecipe(unittest.TestCase):

def setUp(self):
self.output = "./finetune_output"
self.monkeypatch = pytest.MonkeyPatch()

def test_finetune_without_recipe(self):
from llmcompressor import train

recipe_str = None
device = "cuda:0"
self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")

concatenate_data = False
max_steps = 50
Expand All @@ -42,3 +44,4 @@ def test_finetune_without_recipe(self):

def tearDown(self):
shutil.rmtree(self.output)
self.monkeypatch.undo()
4 changes: 4 additions & 0 deletions tests/llmcompressor/transformers/finetune/test_oneshot_and_finetune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def tearDown(self):
# TODO: we get really nice stats from finetune that we should log
# stored in results.json
shutil.rmtree(self.output)
self.monkeypatch.undo()


@pytest.mark.integration
Expand All @@ -66,11 +67,14 @@ class TestOneshotAndFinetuneSmall(TestOneshotAndFinetune):
dataset_config_name = None
num_train_epochs = None
concat_txt = None
monkeypatch = pytest.MonkeyPatch()

def setUp(self):
import torch

self.device = "cuda:0" if torch.cuda.is_available() else "cpu"
if self.device == "cuda:0":
self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")
self.output = "./finetune_output"

def test_oneshot_then_finetune_small(self):
Expand Down
Loading