-
Notifications
You must be signed in to change notification settings - Fork 116
[Compression] Update sparsity calculation lifecycle when fetching the compressor #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, the functionality seems to be all there! LGTM pending a small nit and some clean up (docstrings and such)
src/llmcompressor/transformers/sparsification/compressed_tensors_utils.py
Outdated
Show resolved
Hide resolved
tests/llmcompressor/transformers/sparsification/test_compress_tensor_utils.py
Show resolved
Hide resolved
tests/llmcompressor/transformers/finetune/test_oneshot_and_finetune_with_tokenizer.py
Outdated
Show resolved
Hide resolved
…etune_with_tokenizer.py Co-authored-by: Brian Dellabetta <[email protected]>
Summary
1. No longer always infer sparsity
skip_compression_stats
parameter2. Change the name of
skip_compression_stats
toskip_sparsity_compression_stats
and set to True by default3. Rename
sparsity_config
tosparsity_metadata_config
for clarity4. Add additional log outputs to make it a lot more clear as to what steps are running
5. Fix log outputs to prevent cutting off
Follow-ups:
Testing
For all cases, the model compresses to the expected format.