[Minor Improvements] Vllmruntime Autoscaling in Operator#918
Merged
aeon-x merged 3 commits intoApr 21, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds AvailableReplicas, UpdatedReplicas, and UnavailableReplicas to the VLLMRuntime status and updates the controller to populate these from the Deployment. It also introduces logic to detect --served-model-name overrides in ExtraArgs and increases the Prometheus query interval to 2m. Feedback indicates that the argument parsing logic should be expanded to handle space-separated values to ensure the model name is correctly identified in all common Kubernetes configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three improvements to VLLMRuntime KEDA autoscaling:
Changes:
Tests Done: