Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c35714f5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0385fdd to
dc05d1e
Compare
dc05d1e to
8d88d15
Compare
8d88d15 to
7e94458
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d88d153c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4d15d57 to
ed0c3d5
Compare
ed0c3d5 to
0971b39
Compare
Signed-off-by: Bruno Volpato <brunocvcunha@gmail.com>
0971b39 to
9d43e1c
Compare
Purpose
Extensions can expose inference-generate-compatible endpoints beyond
/inference/v1/generate. Addextra_generate_pathsand--extra-generate-pathsso configured endpoints use existing typed routing instead of transparent fallback.Configured paths:
InferenceGenerateRequesttoken_idsfor cache-aware routingBuilt-in handlers and unconfigured fallback behavior remain unchanged. Invalid, duplicate, dynamic, or conflicting paths fail startup validation.
Cancellation-safe global load accounting remains separate in #200. Related consumer update: NovaSky-AI/SkyRL#1988.
Test Plan
/custom/v1/generateagainst two delayed workers.Test Result
make fmt: passed.make check: passed with three existing Clippy warnings.cargo test --all-features: passed, including 486 library tests and 48 API endpoint tests.uv run --extra dev pytest py_test/unit -q: 109 passed, 4 skipped.uvx black --check: passed for touched Python files.uvx ruff check: passed for touched Python files.git diff --check: passed.Essential Elements of an Effective PR Description Checklist