[CI][ROCm] Add NIXL PD e2e test - #218
Conversation
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
| @@ -1,279 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This one was
- moved to rocm/ folder
- modified to utilize shared utils from the _pd_rocm_common.sh (like
pd_rocm_wait_for_health)
Point 2 was done as the ROCm NIXL tests also need these utils
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
simondanielsson
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f667690536
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Failing Trivy scanner fixed here: #212 |
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
1 participant
Purpose
Fixes remainder of #142. Follow-up to #202.
nvidia/androcm/subfolders.Note: will not run in fork PR's. Only runs in post-merge builds or nightly CI, similar to the MoRI tests added in #202.
Part of: vllm-project/vllm#44091
Scope
Currently tests only
We can broaden this in follow-up PRs (e.g. other backends, xPyD, heterogenous TP, gfx950 with pensando AINIC ...)
Test Plan
CI and trusted ui build succeeds. (note trivy issue is fixed in #212)
Test Result
TODO
Essential Elements of an Effective PR Description Checklist