Minor pd_router cleanups - #227
Open
nt591 wants to merge 1 commit into
Open
Conversation
I'm new to the project but experienced in Rust professionally. I was reading the source and saw some minor cleanups that hopefully are useful. 1) No need to re-parse the worker url 2) replacing an `is_some()` + `unwrap()` with a proper binding Signed-off-by: Nikhil Thomas <nikhil@nthomas.org>
nt591
force-pushed
the
nzthomas/pd_router_cleanup
branch
from
August 31, 2026 20:57
adae32f to
5ad37e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm new to the project but experienced in Rust professionally. I was reading the source and saw some minor cleanups that hopefully are useful.
is_some()+unwrap()with a proper bindingPurpose
Nonfunctional change, solely a common-Rust-style refactor
Test Plan
cargo check, cargo clippy, cargo fmt, uvx pre-commit run --all-files
Test Result
clean
Essential Elements of an Effective PR Description Checklist