fix: clean worker indexes on re-registration - #289
Open
DatenpflegeNordHL wants to merge 1 commit into
Open
DatenpflegeNordHL wants to merge 1 commit into
DatenpflegeNordHL wants to merge 1 commit into
Conversation
Signed-off-by: DatenpflegeNordHL <kontakt@datenpflege-nord.de>
hsliuustc0106
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at 64caf081. Correct fix: previously, re-registering a worker by URL (e.g. after a model/type/label change) left stale entries in type_workers, connection_workers, and the model indexes. register() now purges all secondary indexes via remove_inner while preserving the WorkerId, and the new mutation_lock serializes the multi-map mutations (no lock nesting — public remove/remove_by_url route through the same inner path). The test covering label change + type change + removal is thorough. No findings.
From an automated daily review pass over new/updated PRs (head SHA frozen at 64caf081).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #255