Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] 7/N API Server: Update LM-Eval To Use Streaming #11590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[V1] 7/N API Server: Update LM-Eval To Use Streaming #11590

wants to merge 1 commit into from
+63 −61

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Dec 28, 2024 •
edited by github-actions bot
Loading

SUMMARY:

  • made custom fork of LM-EVAL to use streaming
  • use this as the test for VLLM

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic changed the title [V1] 7/N Update LM-Eval To Use Streaming [V1] 7/N API Server: Update LM-Eval To Use Streaming Dec 28, 2024
@mergify mergify bot added the ci/build label Dec 28, 2024
simon-mo
simon-mo reviewed Dec 29, 2024
View reviewed changes
requirements-test.in
@@ -22,7 +22,7 @@ transformers_stream_generator # required for qwen-vl test
matplotlib # required for qwen-vl test
mistral_common[opencv] >= 1.5.0 # required for pixtral test
datamodel_code_generator # required for minicpm3 test
lm-eval[api]==0.4.4 # required for model evaluation test
lm-eval[api] @ git+https://github.com/robertgshaw2-neuralmagic/lm-evaluation-harness.git@streaming-api # required for model evaluation test with streaming
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sending a PR up?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not planning on upstreaming this since its a hack

@simon-mo simon-mo enabled auto-merge (squash) December 30, 2024 20:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertgshaw2-neuralmagic @simon-mo