-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Support MulAndSilu #11624
base: main
Are you sure you want to change the base?
[Kernel] Support MulAndSilu #11624
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
IIRC we had this kernel before but removed, because of the introduction of torch compile? |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Jee Jee Li <[email protected]>
@comaniac Thanks for your review. If there are other considerations that don't support this operator, I will close this PR, also cc @youkaichao |
Currently there are 3 models in vllm that use this activation function: jais, ultravox and molmo. Implementing this kernel helps improve the performance of these models.
PS : It appears JAIS has different activation function choices, so keeping it unchanged for now.
ping @WoosukKwon @tlrmchlsmth