Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix a bug in loading safetensors #1732

Merged
merged 3 commits into from
Nov 20, 2023
Merged

[BugFix] Fix a bug in loading safetensors #1732

merged 3 commits into from
Nov 20, 2023

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Nov 20, 2023 •
edited
Loading

This PR fixes a bug introduced in #1688

The fix is necessary because otherwise we get the following error:

  File "/workspace/vllm/vllm/model_executor/weight_utils.py", line 243, in hf_model_weights_iterator
    for name in f:
TypeError: 'builtins.safe_open' object is not iterable

@WoosukKwon
Copy link
Collaborator Author

@simon-mo How can I suppress the ruff error?

@simon-mo simon-mo merged commit f5a37c6 into main Nov 20, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the fix-safetensors branch November 20, 2023 23:53
@WoosukKwon
Copy link
Collaborator Author

@simon-mo Thanks for the quick review and fix!

hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@WoosukKwon
[BugFix] Fix a bug in loading safetensors (vllm-project#1732)
fb6865a
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
@WoosukKwon
[BugFix] Fix a bug in loading safetensors (vllm-project#1732)
f2c864f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoosukKwon @simon-mo